Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ExtruderPanel): add _ prefix to gcode_state name #1989

Merged

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Sep 3, 2024

Description

This PR combine the sendRetract & sendExtrude function and add a _ as prefix to the gcode_state.

Related Tickets & Documents

Suggestion from @pedrolamas in the control panel PR: #1988 (comment)

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

none

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested review from dw-0, rackrick and mryel00 September 3, 2024 19:12
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 4, 2024
@meteyou meteyou merged commit 5cb3080 into mainsail-crew:develop Sep 4, 2024
12 checks passed
@meteyou meteyou deleted the refactor/extrude-control-panel branch September 4, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants